Fix NPE issues during host rolling maintenance, due to host tags and custom constrained/unconstrained service offering #9844

sureshanaparti · 2024-10-23T11:37:06Z

Description

This PR fixes NPE issues during host rolling maintenance, due to host tags and custom constrained/unconstrained service offering.

Fixes #9834 & #9836

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Tested host rolling maintenance with custom constrained/unconstrained service offering & service offering without host tags, checked the rolling maintenance cmd sent to KVM host without any NPEs.

How did you try to break this feature and the system with this change?

sureshanaparti · 2024-10-23T11:40:30Z

@blueorangutan package

codecov · 2024-10-23T11:45:01Z

Codecov Report

Attention: Patch coverage is 42.85714% with 20 lines in your changes missing coverage. Please review.

Project coverage is 15.13%. Comparing base (afc95f1) to head (7cc7bac).
Report is 8 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
.../cloud/resource/RollingMaintenanceManagerImpl.java	42.85%	15 Missing and 5 partials ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19    #9844   +/-   ##
=========================================
  Coverage     15.12%   15.13%           
- Complexity    11268    11272    +4     
=========================================
  Files          5408     5408           
  Lines        473954   473983   +29     
  Branches      57810    57818    +8     
=========================================
+ Hits          71709    71724   +15     
- Misses       394231   394240    +9     
- Partials       8014     8019    +5

Flag	Coverage Δ
uitests	`4.30% <ø> (ø)`
unittests	`15.85% <42.85%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sureshanaparti · 2024-10-23T11:53:06Z

@blueorangutan package

blueorangutan · 2024-10-23T11:54:07Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-10-23T12:49:43Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11417

sureshanaparti · 2024-10-24T09:57:50Z

@blueorangutan test

blueorangutan · 2024-10-24T10:00:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-10-24T23:48:18Z

[SF] Trillian test result (tid-11695)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47478 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9844-t11695-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_secured_to_nonsecured_vm_migration	`Error`	441.17	test_vm_life_cycle.py

vishesh92

clgtm. didn't test

DaanHoogland

clgtm

server/src/main/java/com/cloud/resource/RollingMaintenanceManagerImpl.java

borisstoyanov

LGTM, following the steps I couldn't reproduce

sureshanaparti · 2024-11-05T15:51:11Z

@blueorangutan package

blueorangutan · 2024-11-05T15:52:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-11-05T16:31:24Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 11510

sureshanaparti · 2024-11-06T04:38:47Z

@blueorangutan package

blueorangutan · 2024-11-06T04:40:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-11-06T06:02:41Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11515

harikrishna-patnala

code LGTM

rohityadavcloud · 2024-11-07T09:05:40Z

@blueorangutan test

blueorangutan · 2024-11-07T09:08:05Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-11-07T22:15:45Z

[SF] Trillian test result (tid-11759)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 44924 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9844-t11759-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

server/src/main/java/com/cloud/resource/RollingMaintenanceManagerImpl.java

…custom constrained/unconstrained service offering

sureshanaparti · 2025-01-09T07:52:23Z

@blueorangutan package

blueorangutan · 2025-01-09T07:54:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

server/src/main/java/com/cloud/resource/RollingMaintenanceManagerImpl.java

…gerImpl.java

blueorangutan · 2025-01-09T08:47:08Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12022

blueorangutan · 2025-01-09T10:12:36Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12023

DaanHoogland · 2025-01-09T10:20:48Z

@JoaoJandre @BryanMLima , are you ok with this?

DaanHoogland · 2025-01-10T15:21:55Z

@blueorangutan test

blueorangutan · 2025-01-10T15:24:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-01-11T05:20:03Z

[SF] Trillian test result (tid-12083)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47642 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9844-t12083-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2025-01-13T08:24:58Z

@JoaoJandre @BryanMLima , are you ok with this?

ping, sorry for the pressurem but I'd like to get as much in for 4.19 as possible.

* 4.20: linstor: Fix ZFS snapshot backup (#10219) fix listing of VMs by network (#10204) Configure org.eclipse.jetty.server.Request.maxFormKeys from server.properties and increase the default value (#10214) api: fix access for listSystemVmUsageHistory (#10032) Fix NPE issues during host rolling maintenance, due to host tags and custom constrained/unconstrained service offering (#9844)

…custom constrained/unconstrained service offering (apache#9844)

This was linked to issues Oct 23, 2024

NPE during host rolling maintenance when host has VMs with custom constrained/unconstrained service offering #9836

Closed

NPE during host rolling maintenance when host has tag and service offering doesn't have host tag #9834

Closed

sureshanaparti requested review from nvazquez and vishesh92 October 23, 2024 11:40

sureshanaparti added this to the 4.19.2.0 milestone Oct 23, 2024

vishesh92 approved these changes Oct 25, 2024

View reviewed changes

DaanHoogland approved these changes Oct 28, 2024

View reviewed changes

server/src/main/java/com/cloud/resource/RollingMaintenanceManagerImpl.java Outdated Show resolved Hide resolved

JoaoJandre reviewed Oct 30, 2024

View reviewed changes

borisstoyanov self-assigned this Nov 1, 2024

borisstoyanov approved these changes Nov 1, 2024

View reviewed changes

sureshanaparti requested a review from JoaoJandre November 5, 2024 15:51

harikrishna-patnala approved these changes Nov 7, 2024

View reviewed changes

JoaoJandre reviewed Nov 8, 2024

View reviewed changes

server/src/main/java/com/cloud/resource/RollingMaintenanceManagerImpl.java Outdated Show resolved Hide resolved

sureshanaparti added 3 commits January 9, 2025 12:34

Fix NPE issues during host rolling maintenance, due to host tags and …

9bbb37c

…custom constrained/unconstrained service offering

review comments & tests

d8d1048

addressed comments

0e853e9

sureshanaparti force-pushed the rolling-maintenance-npe-issue branch from e5e60d8 to 0e853e9 Compare January 9, 2025 07:50

sureshanaparti commented Jan 9, 2025

View reviewed changes

server/src/main/java/com/cloud/resource/RollingMaintenanceManagerImpl.java Outdated Show resolved Hide resolved

Update server/src/main/java/com/cloud/resource/RollingMaintenanceMana…

7cc7bac

…gerImpl.java

DaanHoogland merged commit c5e8f63 into apache:4.19 Jan 20, 2025
26 checks passed

DaanHoogland deleted the rolling-maintenance-npe-issue branch January 20, 2025 12:20

This was referenced Jan 20, 2025

NPE during host rolling maintenance when host has tag and service offering doesn't have host tag #9834

Closed

NPE during host rolling maintenance when host has VMs with custom constrained/unconstrained service offering #9836

Closed

rg9975 pushed a commit to rg9975/cloudstack that referenced this pull request Jan 31, 2025

Fix NPE issues during host rolling maintenance, due to host tags and …

0e66495

…custom constrained/unconstrained service offering (apache#9844)

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025

Fix NPE issues during host rolling maintenance, due to host tags and …

e6e54c6

…custom constrained/unconstrained service offering (apache#9844)

Fix NPE issues during host rolling maintenance, due to host tags and custom constrained/unconstrained service offering #9844

Fix NPE issues during host rolling maintenance, due to host tags and custom constrained/unconstrained service offering #9844

Uh oh!

Conversation

sureshanaparti commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Oct 23, 2024

Uh oh!

codecov bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sureshanaparti commented Oct 23, 2024

Uh oh!

blueorangutan commented Oct 23, 2024

Uh oh!

blueorangutan commented Oct 23, 2024

Uh oh!

sureshanaparti commented Oct 24, 2024

Uh oh!

blueorangutan commented Oct 24, 2024

Uh oh!

blueorangutan commented Oct 24, 2024

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Nov 5, 2024

Uh oh!

blueorangutan commented Nov 5, 2024

Uh oh!

blueorangutan commented Nov 5, 2024

Uh oh!

sureshanaparti commented Nov 6, 2024

Uh oh!

blueorangutan commented Nov 6, 2024

Uh oh!

blueorangutan commented Nov 6, 2024

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

rohityadavcloud commented Nov 7, 2024

Uh oh!

blueorangutan commented Nov 7, 2024

Uh oh!

blueorangutan commented Nov 7, 2024

Uh oh!

Uh oh!

sureshanaparti commented Jan 9, 2025

Uh oh!

blueorangutan commented Jan 9, 2025

Uh oh!

Uh oh!

blueorangutan commented Jan 9, 2025

Uh oh!

blueorangutan commented Jan 9, 2025

Uh oh!

DaanHoogland commented Jan 9, 2025

Uh oh!

sureshanaparti commented Oct 23, 2024 •

edited

Loading

codecov bot commented Oct 23, 2024 •

edited

Loading